Bluetooth: Classic: L2CAP: Reset rx.cid when channel is deleted #94633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
zephyrbot
requested review from
MarkWangChinese,
jhedberg,
lylezhu2012 and
makeshi
lylezhu2012
requested changes
Aug 19, 2025
rootcause: The dynamic L2CAP channel rx.cid is not reset, it will be intercepted by the judgment condition of the fixed channel, directly using the last alloced cid may cause cid conflict. Signed-off-by: zhenwei fang <fangzhenwei@bytedance.com>
Frozen935
force-pushed
the
fix_l2cap_br
branch
from
454691f to
78a6dca
Compare
|
chengkai15
reviewed
Aug 20, 2025
| bt_l2cap_br_chan_set_state(chan, BT_L2CAP_DISCONNECTED); | ||
| BR_CHAN(chan)->psm = 0U; | ||
| if (L2CAP_BR_CID_IS_DYN(BR_CHAN(chan)->rx.cid)) { | ||
| BR_CHAN(chan)->rx.cid = 0U; |
Contributor
There was a problem hiding this comment.
need to reset all rx bt_l2cap_br_endpoint？
will tx enpoint be the potential problems？
Contributor
Author
There was a problem hiding this comment.
tx enpoint don't need
lylezhu2012
approved these changes
Aug 20, 2025
chengkai15
approved these changes
Aug 20, 2025
Contributor
|
@Frozen935 , Why did you close this PR? |
Contributor
Author
CI build break, and I force pushed the rebase, this PR can't reopen. I will submit a new PR later. |
Contributor
|
I crated a #98473 for the changes of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rootcause: the dynamic L2CAP channel rx.cid is not reset, it will be intercepted by the judgment condition of the fixed channel, directly using the last alloced cid may cause cid conflict.
For example, the first BR L2CAP channel is an SDP service, and the chan requested from bt_sdp_pool occupies cid 0x40. When the sdp connection is disconnected, it will be removed from the conn->channels list, but the bt_sdp_pool[0] cid field is not cleanup. A new service request may be A2DP or HFP, which will request cid 0x40. When the next sdp service request is received, the chan rx.cid received will not be 0, and this chan will be used directly instead of dynamically requesting a new cid, which will cause a cid conflict.