Skip to content

net: Do not access possibly freed net_pkt #98476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

net: Do not access possibly freed net_pkt #98476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions subsys/net/ip/net_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,8 @@ static inline bool process_multicast(struct net_pkt *pkt)

int net_try_send_data(struct net_pkt *pkt, k_timeout_t timeout)
{
struct net_if *iface;
int family;
int status;
int ret;

Expand Down Expand Up @@ -439,18 +441,27 @@ int net_try_send_data(struct net_pkt *pkt, k_timeout_t timeout)
}
#endif

/* The pkt might contain garbage already after the call to
* net_if_try_send_data(), so do not use pkt after that call.
* Remember the iface and family for statistics update.
*/
if (IS_ENABLED(CONFIG_NET_STATISTICS)) {
iface = net_pkt_iface(pkt);
family = net_pkt_family(pkt);
}

if (net_if_try_send_data(net_pkt_iface(pkt), pkt, timeout) == NET_DROP) {
ret = -EIO;
goto err;
}

if (IS_ENABLED(CONFIG_NET_STATISTICS)) {
switch (net_pkt_family(pkt)) {
switch (family) {
case AF_INET:
net_stats_update_ipv4_sent(net_pkt_iface(pkt));
net_stats_update_ipv4_sent(iface);
break;
case AF_INET6:
net_stats_update_ipv6_sent(net_pkt_iface(pkt));
net_stats_update_ipv6_sent(iface);
break;
}
}
Expand Down