Skip to content

Conversation

@eszSTM
Copy link

@eszSTM eszSTM commented Oct 29, 2025

STM32MP135F_DK board embeds a LCD screen with touchscreen driven by I2C5. GT911 touchscreen already have driver support in Zephyr so just add necessary nodes here.

@github-actions
Copy link

Hello @eszSTM, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you break the commit message body 2nd line to fit in 74 chars?
Also, for consistency, prefer use `boards: st: stm32mp135F_dk: in the header line.

-boards: stm32mp135f_dk: add touchscreen and lvgl pointer
+boards: st: stm32mp135f_dk: add touchscreen and lvgl pointer
 
 STM32MP135F_DK board embeds a LCD screen with touchscreen driven by I2C5.
-GT911 touchscreen already have driver support in Zephyr so just add necessary nodes here.
+GT911 touchscreen already have driver support in Zephyr so just add
+necessary nodes here.
 
 Signed-off-by: ...

STM32MP135F_DK board embeds a LCD screen with touchscreen driven by I2C5.
GT911 touchscreen already have driver support in Zephyr so just add
necessary nodes here.

Signed-off-by: Erwan SZYMANSKI <erwan.szymanski@st.com>
@eszSTM eszSTM force-pushed the esz/stm32mp135f_dk_touchscreen branch from 593c93c to cadfc14 Compare October 29, 2025 13:53
@eszSTM
Copy link
Author

eszSTM commented Oct 29, 2025

Modifications done after @etienne-lms comments

@sonarqubecloud
Copy link

@mathieuchopstm mathieuchopstm added this to the v4.4.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants