kernel: events: Depend on multithreading #98489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
added
the
Trivial
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
Kernel events depend on multithreading being enabled, and mixing them with a non-multithreaded build gives linker failures internal to events.c. To avoid this, make events depend on multithreading. ``` libkernel.a(events.c.obj): in function `k_event_post_internal': 175: undefined reference to `z_sched_waitq_walk' events.c:183: undefined reference to `z_sched_wake_thread' events.c:191: undefined reference to `z_reschedule' libkernel.a(events.c.obj): in function `k_sched_current_thread_query': kernel.h:216: undefined reference to `z_impl_k_sched_current_thread_query' libkernel.a(events.c.obj): in function `k_event_wait_internal': events.c:312: undefined reference to `z_pend_curr' ``` Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
events-depend-multithreading
branch
from
ed4a9a7 to
8118545
Compare
|
peter-mitsis
approved these changes
Oct 29, 2025
Contributor
peter-mitsis
left a comment
peter-mitsis
left a comment
There was a problem hiding this comment.
The failing CI test does not appear to be related to the proposed change.
anangl
approved these changes
Oct 30, 2025
nordicjm
approved these changes
Oct 30, 2025
tejlmand
approved these changes
Oct 30, 2025
Member
|
@carlescufi I see this in the summary of the latest Seems likely to be related to this PR? |
Member
Looks like it's coming from this: The full(er) error is this: That looks pretty strange to me - why something from an espressif soc file for a qemu build? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel events depend on multithreading being enabled, and mixing them with a non-multithreaded build gives linker failures internal to events.c. To avoid this, make events depend on multithreading.