Skip to content

net: l2: openthread: border_router: Delete multicast route by iface #98856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2025
Merged

net: l2: openthread: border_router: Delete multicast route by iface #98856

merged 1 commit into from
Nov 13, 2025

Conversation

@Cristib05
Copy link
Contributor

@Cristib05 Cristib05 commented Nov 4, 2025

This commit makes use of #98464 and deletes a multicast route by specified interface.

@zephyrbot zephyrbot added area: OpenThread size: XS A PR changing only a single line of code area: Networking labels Nov 4, 2025
rlubos
rlubos reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the line length

@Cristib05 Cristib05 force-pushed the border_router_del_mcast_by_iface branch from ad1e187 to c6b1575 Compare November 4, 2025 15:17
@Cristib05
Copy link
Contributor Author

Cristib05 commented Nov 4, 2025

Please fix the line length

did it, completely forgot about this :(

jukkar
jukkar previously approved these changes Nov 4, 2025
View reviewed changes
pdgendt
pdgendt previously approved these changes Nov 4, 2025
View reviewed changes
rlubos
rlubos previously approved these changes Nov 4, 2025
View reviewed changes
@Cristib05
net: l2: openthread: border_router: Delete multicast route by iface
8c74e35 
This commit makes use of zephyrproject-rtos#98464 and deletes a multicast route by
specified interface.

Signed-off-by: Cristian Bulacu <cristian.bulacu@nxp.com>
@Cristib05 Cristib05 dismissed stale reviews from rlubos, pdgendt, and jukkar via 8c74e35 November 4, 2025 15:56
@Cristib05 Cristib05 force-pushed the border_router_del_mcast_by_iface branch from c6b1575 to 8c74e35 Compare November 4, 2025 15:56
@Cristib05
Copy link
Contributor Author

Cristib05 commented Nov 4, 2025

Added net_if_ipv6_maddr_rm, after multicast group was left and route was deleted

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cfriedt cfriedt added this to the v4.4.0 milestone Nov 6, 2025
@cfriedt
Copy link
Member

cfriedt commented Nov 6, 2025

Just assuming this is a feature addition, so I added the 4.4.0 milestone. If that was not the right assumption, please ping.

@Cristib05
Copy link
Contributor Author

Cristib05 commented Nov 6, 2025 •
edited
Loading

Just assuming this is a feature addition, so I added the 4.4.0 milestone. If that was not the right assumption, please ping.

It is a continuation of #98464 which has been merged last week, it would be nice to have this in the current release, to avoid some issues

@jhedberg jhedberg merged commit 4520215 into zephyrproject-rtos:main Nov 13, 2025
29 checks passed
@Cristib05
Copy link
Contributor Author

Cristib05 commented Nov 19, 2025

@rlubos, do you think it would be possible to add the content of this PR as backport? And for this #98972 as well?

@rlubos
Copy link
Contributor

rlubos commented Nov 19, 2025

@Cristib05 It'd require a bug report, but it shouldn't be a problem if you just create an issue for those.

@Cristib05 Cristib05 mentioned this pull request Nov 19, 2025
Open
1 task
@pdgendt pdgendt added the backport v4.3-branch Request backport to the v4.3-branch label Nov 19, 2025
@github-actions github-actions bot mentioned this pull request Nov 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jukkar jukkar jukkar approved these changes

@rlubos rlubos rlubos approved these changes

@canisLupus1313 canisLupus1313 Awaiting requested review from canisLupus1313

@edmont edmont Awaiting requested review from edmont

@maciejbaczmanski maciejbaczmanski Awaiting requested review from maciejbaczmanski

@ssharks ssharks Awaiting requested review from ssharks

@pdgendt pdgendt Awaiting requested review from pdgendt

Assignees

@jukkar jukkar

@rlubos rlubos

Labels

area: Networking area: OpenThread backport v4.3-branch Request backport to the v4.3-branch size: XS A PR changing only a single line of code

Projects

None yet

Milestone

v4.4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Cristib05 @cfriedt @rlubos @jukkar @pdgendt @jhedberg @zephyrbot