Tell the user the address that failed to connect. #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current: ``` Caused by: org.zeromq.ZMQException: blah-blah : Address not available ``` Yes, but _which_ address?? New error (I think?): ``` Caused by: org.zeromq.ZMQException: failed connecting to 0.0.0.0:5678: blah-blah : Address not available ```
Author
|
I'm new-ish to github, and have no clue if builds/tests are running on this PR. Sorry if I should have waited for them before sending out for review. |
Contributor
|
I think you should use the |
Author
Sorry, could you share more? What is |
Contributor
|
Just look at the argument of the function: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current:
Yes, but which address??
New error (I think?):