Fix: segfault when executable can't find image assets#3
Open
rilysh wants to merge 1 commit intozeropolis79:mainfrom
Open
Fix: segfault when executable can't find image assets#3rilysh wants to merge 1 commit intozeropolis79:mainfrom
rilysh wants to merge 1 commit intozeropolis79:mainfrom
Conversation
dazzlesoftware
approved these changes
May 30, 2023
polluks2
suggested changes
May 30, 2023
polluks2
left a comment
polluks2
left a comment
There was a problem hiding this comment.
After "Failed to open audio device: ALSA: Couldn't open audio device: No such file or directory" please proceed in silence...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR fixes the crash that happens when petsciirobots can't find image assets, which are located inside the
SDLfolder. Also, when an error occurred (e.g. if SDL fails to load) it doesn't seem like that the program exits but passes aNULLpointer which will also cause a segmentation fault. I've added exit(3) for this.Referring the issue: #2