Improve reliability of ServiceClient #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids always creating new connections, leading to excessive lingering TCP connections in TIME_WAIT state if the ZeroTier system service is unavailable.
…nnection failed, and vice-versa
|
|
joseph-henry
approved these changes
Nov 11, 2025
Contributor
joseph-henry
left a comment
joseph-henry
left a comment
There was a problem hiding this comment.
Thank you for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to improve the reliability of
ServiceClient, by:ureq::Agentand its connection pool (leaving the size of the connection pool at the default of 1 connection). This makesServiceClientable to re-use connections, reducing the amount of lingering TCP connections in TIME_WAIT state in the case that the ZeroTierOne service is not available.