Skip to content

Support Shizuku alongside Sui #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xIO32 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Shizuku alongside Sui #1435

0xIO32 wants to merge 2 commits into from

Conversation

@0xIO32
Copy link

@0xIO32 0xIO32 commented Jun 9, 2025

Not a large change, but both Sui and Shizuku use the Shizuku-Api.

Currently Material Files only supports Sui.
Shizuku seems to be more maintained than sui. Shizuku supports root as well as rootless (Sui only with root).

This pr adds a small change, that allows Shizuku to be used as well.

@0xIO32
Copy link
Author

0xIO32 commented Jun 13, 2025

Fixes #1274

@0xIO32
Copy link
Author

0xIO32 commented Jun 14, 2025

First of all, thank you for your interest in help improving this project! However, I normally won't accept PRs for this project because I'm currently the only copyright owner for it (except for translations and maybe my company), which I think would be a nice thing to keep along. On the other hand, forcing people to give up their copyright to me is both awkward and legally-complex. So if you have any suggestions for an improvement, please feel free to comment on existing issues or open a new one!

@zhanghai If it is required for this pr to be merged, you can have the copyright.

adambog-comiks
adambog-comiks reviewed Jun 16, 2025
View reviewed changes
Copy link

@adambog-comiks adambog-comiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/src/main/AndroidManifest.xml

app/src/main/AndroidManifest.xml
<uses-sdk tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared,rikka.shizuku.provider" />

<!--
~ Samsung DeX requires explicitly setting android:resizeableActivity="true" for the app to be
Copy link

@adambog-comiks adambog-comiks Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared

@Algiuxs
Copy link

Algiuxs commented Aug 19, 2025

@zhanghai will this get merged?

MasterCraft6969
MasterCraft6969 approved these changes Dec 24, 2025
View reviewed changes
Copy link

@MasterCraft6969 MasterCraft6969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuinely a needed feature

@0xIO32
Copy link
Author

0xIO32 commented Dec 24, 2025

Genuinely a needed feature

Would be a nice Christmas gift indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@MasterCraft6969 MasterCraft6969 MasterCraft6969 approved these changes

@Algiuxs Algiuxs Algiuxs approved these changes

@adambog-comiks adambog-comiks adambog-comiks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xIO32 @Algiuxs @MasterCraft6969 @adambog-comiks