Skip to content

fix: avoid treating json arguments as config#22

Open
pjiaquan wants to merge 2 commits intozhangjingwei:mainfrom
pjiaquan:fix/upload-json-config-detection
Open

fix: avoid treating json arguments as config#22
pjiaquan wants to merge 2 commits intozhangjingwei:mainfrom
pjiaquan:fix/upload-json-config-detection

Conversation

@pjiaquan
Copy link
Copy Markdown

Summary

  • only treat a positional .json argument as legacy config when it loads as a valid kuake config
  • preserve the underlying config load error during client initialization
  • add parser coverage for valid config vs ordinary json files

Testing

  • env GOCACHE=/tmp/kuake-go-build go test ./cmd -run TestIsLegacyConfigArg
  • env GOCACHE=/tmp/kuake-go-build go test ./sdk -run 'TestNewQuarkClient|TestLoadConfig'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant