Add install requirements and fix installation errors #23
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes installation errors due to the install_requirements specified not being available during install time when setup.py is run. To fix this a static .version file is created, removing the need for having the package version to be specified in __init__.py of the pyscopus package. Summary of Changes: - Removed __version__ attribute from __init__.py - Added static .version file to contain the current package version - Removed import of pyscopus in setup.py to fix installation error - Changed `HERE` directory to `ROOT_DIR` and preferred use of Path class over os.path.abspath
This commit will enable setuptools to use the SCM (in this case Git) version tags. The fallback when Git is unavailable is then the static version stored in the .version file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds installation_requirements to setup.py and fixes the
installation errors due to these requirements not being available during
install time when setup.py is run. To fix this a static .version file is
created, removing the need for having the package version to be
specified in init.py of the pyscopus package. Furthermore,
setuptools_scm is use to get the latest Git tag when available.
Therefore, when the package is installed with a newer Git tag than the
static version available in .version; this file will be updated and
can later be commited.
Summary of Changes:
HEREdirectory toROOT_DIRand preferred use of Pathclass over os.path.abspath
a fallback version from the .version file