Adjusted bindings to match OpenGL-Registry(/api/GL/glcorearb.h) more closely #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closely * converted non-void pointers to '[*c]' (C pointers) * converted void pointers to '?*anyopaque' * converted non-GL types to GL types * added 'const' where needed * adjusted argument names to match those in the registry
* makes it possible to unset the debug callback, by passing in 'null'
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes pointer type declarations in OpenGL bindings for Zig, converting from inconsistent pointer types to the more appropriate [*c] (C pointer) convention and nullable optionals where appropriate.
Key changes include:
- Converting single-item pointers (
*const Type) to C pointers ([*c]const Type) for consistency with C FFI - Converting bare pointer types to nullable optionals (
?*const anyopaque) where nullability is semantically valid - Renaming parameters to match OpenGL specification conventions (e.g.,
binary_formattobinaryFormat,shader_typetoshadertype) - Removing unnecessary
@"type"escaping in parameter names
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General adjustments:
[*c](C pointers),?*anyopaque,constwhere needed,Additional specific changes:
paramsargument forgetPointervandgetPointervKHR(void*->void**),callbackargument ofdebugMessageCallbackanddebugMessageCallbackKHRoptional, so debug callback can be unset by passingnull.