Skip to content

Conversation

@lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Nov 3, 2025

Pre-submission checks

Please check these boxes:

  • Mandatory: This PR corresponds to an issue (if not, please create
    one first).

  • I hereby disclose the use of an LLM or other AI coding assistant in the
    creation of this PR. PRs will not be rejected for using AI tools, but
    will be rejected for undisclosed use.

    Some autocomplete jumped up and I might have accepted one or two before getting annoyed as usual. I don't really remember, it's getting late lol. I changed my approach tho, so probably no AI slop in the final PR.

    I had it review my pared down which impl to double check I didn't miss anything, it pointed out some mistakes.

Summary

On macOS, apps don't pick up the path, so you'd have to manually set the zizmor (see #27). This adds in support for falling back to commonly installed locations. This also handles the case that exePath is an empty string, as the setting GUI is prone to do (as I discovered in testing).

Fixes #29

The implementation is shameless copied heavily based & modified from JJK's implementation [MIT], and also includes portions of which [ISC] & (trivially) @types/which [MIT].

Test Plan

Test with it in path, not in path, etc etc.
Seemed to work for me but should check on Windows, etc.

@lishaduck lishaduck force-pushed the exepath2 branch 2 times, most recently from 807166c to d169098 Compare November 5, 2025 14:52
@lishaduck lishaduck force-pushed the exepath2 branch 3 times, most recently from c38927f to 4c5857b Compare November 11, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requires manually setting the Zizmor path on macOS

2 participants