Draft
Conversation
Followup to zkcrypto#46 which attempted to change an assertion for the window size from `<= 64` to `< 64`, which was in response to the `width` type being `u64` and its value computed as `1 << window`, which would overflow a `u64`. This means `width` needs an extra bit, so this promotes it to a `u128` while keeping any variables that can remain `u64` as they were.
tarcieri
commented
Feb 7, 2026
Comment on lines
+149
to
+150
| // Remove trailing zeros left by the loop above | ||
| wnaf.truncate(wnaf.len().saturating_sub(window - 1)); |
Contributor
Author
There was a problem hiding this comment.
One of the requests from #46 was for a comment on the above. Unfortunately I wasn't particularly familiar with what this line is doing and that is the best I could muster. It could probably use a better one.
tarcieri
added a commit
to RustCrypto/group
that referenced
this pull request
Feb 7, 2026
These are all the commits from the PR opened as zkcrypto#73, squashed into a single commit so I could cherry-pick it onto `rustcrypto-group`, whose history has diverged from upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #46, rebased on top of #72 (which should probably be merged first), with all of the feedback hopefully at least partially addressed