Skip to content

feat(ongeki): make inGameID nullable and update seeds to 2026/02/19#1427

Merged
zkldi merged 20 commits intozkldi:mainfrom
nyairobi:feat/ongeki-optional-igid
Apr 19, 2026
Merged

feat(ongeki): make inGameID nullable and update seeds to 2026/02/19#1427
zkldi merged 20 commits intozkldi:mainfrom
nyairobi:feat/ongeki-optional-igid

Conversation

@nyairobi
Copy link
Copy Markdown
Contributor

@nyairobi nyairobi commented Feb 7, 2026

Making inGameID nullable

#1425 introduced demand for seed parity with JP, and in order to achieve that I need to make inGameID optional, which causes a bit of a mess, as bonus tracks are currently defined as tracks in the ID range [7000, 8000) because I was too stingy about the isUnranked flag (now re-introduced as isBonusTrack). This is closer to the original impl which should have stayed like that.

Re:Fresh folders get screwed by this change, but older versions are complete so they can stay as they are. New folders have the same chart counts as old ones so everything seems alright I guess. I don't remember inGameID being needed for anything else.

One caveat is that the seed tester spams warnings Chart ID x (song ID y) cannot be matched using matchType=inGameID because its inGameID is unknown.

Seeds

  • Updated seeds to 2026/02/19.
  • Reformatted/fixed/updated all search terms.
  • Added more tooling for automating future seeds.
  • Added flavor genres to all relevant songs (BMS and some Ongeki originals); those are genres by the IIDX definition as opposed to the GCM definition (more info here). The data was cross-checked between wikiwiki, SilentBlue and Bokutachi's BMS seeds.

@tachi-repo-bot
Copy link
Copy Markdown

tachi-repo-bot Bot commented Feb 7, 2026

A commit has changed the seeds. View the diff here.

@nyairobi
Copy link
Copy Markdown
Contributor Author

Since this is taking weeks, may as well push other changes.

@nyairobi nyairobi changed the title feat(ongeki): make inGameID nullable feat(ongeki): make inGameID nullable and update seeds to 2026/02/19 Feb 27, 2026
@tachi-repo-bot
Copy link
Copy Markdown

A commit has changed the seeds. View the diff here.

@tachi-repo-bot
Copy link
Copy Markdown

A commit has changed the seeds. View the diff here.

@nyairobi
Copy link
Copy Markdown
Contributor Author

A commit has changed the seeds. View the diff here.

1 similar comment
@tachi-repo-bot
Copy link
Copy Markdown

A commit has changed the seeds. View the diff here.

@nyairobi
Copy link
Copy Markdown
Contributor Author

nyairobi commented Mar 3, 2026

Client tests are now failing because 6523282 is missing the "u" flag

@zkldi zkldi merged commit bbf024c into zkldi:main Apr 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants