fix: update x-backup for Minecraft 1.21.11#50
Merged
zly2006 merged 1 commit intozly2006:stonecutterfrom Jan 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Minecraft 1.21.11 by updating dependencies, mappings, and adapting to API changes in the new version. The changes focus on version compatibility while maintaining backward compatibility through conditional compilation using Stonecutter.
Key changes:
- Updated Fabric Loom from 1.11-SNAPSHOT to 1.13.3 and added Gradle toolchain resolver plugin
- Adapted to Minecraft 1.21.11 API changes: command manager method renaming, new permissions system, and chunk write synchronization
- Refactored backup file handling in BackupDatabaseService to use temporary files, improving race condition handling
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| versions/1.21.11/gradle.properties | New configuration file defining dependencies and mappings for Minecraft 1.21.11 |
| stonecutter.gradle.kts | Updated Fabric Loom version from 1.11-SNAPSHOT to 1.13.3 for 1.21.11 compatibility |
| settings.gradle.kts | Added foojay-resolver-convention plugin for Java toolchain management and registered 1.21.11 version |
| src/main/kotlin/com/github/zly2006/xbackup/XBackup.kt | Changed Json to json (referencing the json val), added ignoreUnknownKeys, and adapted command manager API with version-conditional code |
| src/main/kotlin/com/github/zly2006/xbackup/Utils.kt | Added syncChunkWrites() call for 1.21.11+ to ensure chunks are written to disk |
| src/main/kotlin/com/github/zly2006/xbackup/Commands.kt | Adapted permissions system to use DefaultPermissions API for 1.21.11+ |
| common/src/main/kotlin/com/github/zly2006/xbackup/BackupDatabaseService.kt | Refactored file backup logic to use temporary files with improved race condition handling and error recovery |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
LGTM, Thank you so much! I will do some tests later. |
Owner
|
你好，有没有兴趣处理一下自动重启的问题？应该只有服务端自动关闭，而客户端不会。现在客户端有bug。 |
Contributor
Author
|
您指的是单人模式restore之后游戏报错退出吗？ |
Owner
是的 |
Contributor
Author
|
好的，我空了会尝试改一下，修复后我会pr回来 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Tested
Notes
This PR only focuses on version compatibility, no behavior changes, there are some minor attempts on trying to fix the error mentioned above but only fixed a fraction of the problems.