Skip to content

C compatibility fixes #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fweimer-rh wants to merge 2 commits into
base: 3_5
Choose a base branch
from
Open

C compatibility fixes #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc959bf
configure: Avoid an implicit int in the IPv6 test
fweimer-rh Nov 28, 2023
2979ce9
Fix C type safety issue in CVE-2023-30547 change
fweimer-rh Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client-src/runtar.c
View file
Open in desktop
Copy link

@konidev20 konidev20 Dec 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM

Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ main(
{
#ifdef GNUTAR
int i;
char **j;
const char **j;
char *e;
char *dbf;
char *cmdline;
Expand Down Expand Up @@ -255,7 +255,7 @@ check_whitelist(
gchar* option)
{
bool result = TRUE;
char** i;
const char** i;

for(i=whitelisted_args; *i; i++) {
if (g_str_has_prefix(option, *i)) {
Expand Down
2 changes: 1 addition & 1 deletion config/amanda/ipv6.m4
View file
Open in desktop
Copy link

@konidev20 konidev20 Dec 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this has already been reviewed as a part of #220

Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ AC_DEFUN([AMANDA_CHECK_IPV6],
#include <sys/socket.h>
#include <errno.h>

main()
int main(void)
{
int aa;
aa = socket(AF_INET6, SOCK_STREAM, 0);
Expand Down