Static linking with latest ffmpeg fails with link errors

[msabansal]

Static linking with latest ffmpeg gives the following error:

   avdevice.lib(dshow.o) : error LNK2001: unresolved external symbol IID_IBaseFilter
   avdevice.lib(dshow_filter.o) : error LNK2001: unresolved external symbol IID_IBaseFilter
   
   <snip>
   
   fatal error LNK1120: 32 unresolved externals

Adding the missing libraries to fix it.

[dmtrKovalenko]

which feature flags are you building it for:?

[msabansal]

I installed ffmpeg static build for x264 using the following command:

vcpkg install ffmpeg[x264] --triplet x64-windows-static-md

Running the build after this with the static feature flag fails with the above error.

[dmtrKovalenko]

Can we do this only for windows?

[msabansal]

Is the current change compiled on other platform aswell? Seeing user32 and bcrypt i assumed this branch was windows only

[dmtrKovalenko]

Probably you are right, but this a vcpkg branch which is available on any platform. Not sure how it works in other platforms but I would prefer to not try linking windows libraries at all. Could you add a guard for all of them?

[msabansal]

The try_vcpkg method return None on non msvc environments so looks to be only building on windows here. Would prefer to avoid any additional conditionals.
Thanks for the quick review BTW 👍

[dmtrKovalenko]

great

[msabansal]

checking if this can be retriggered for a merge