Test for 3/1 meter, which results in misbarred notation#37
Open
mjwalter wants to merge 2 commits intozolaemil:masterfrom
Open
Test for 3/1 meter, which results in misbarred notation#37mjwalter wants to merge 2 commits intozolaemil:masterfrom
mjwalter wants to merge 2 commits intozolaemil:masterfrom
Conversation
Owner
|
What do you mean misbarred? Are you expecting the viewer to put bar lines in the middle of measures? |
Contributor
Author
|
My bad—I put the wrong code in (that's for a different problem!). The updated file should show the relevant problem, which seems to be caused by the |
Owner
|
I see, this is probably a MEIToVexFlow issue. Would make sense to make a failing test case there. |
Owner
|
In any case, one issue with this is that the voices don't contain the same amount of beats. |
Contributor
Author
|
They do have the same number of beats. |
Owner
|
Sorry, I see the first measure is the problematic, not the second.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.