Skip to content

Make --test case-insensitive #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from Jul 4, 2023
Merged

Make --test case-insensitive #343

2 commits merged into from Jul 4, 2023

Conversation

@ghost
Copy link

@ghost ghost commented Jul 3, 2023 •
edited by ghost
Loading

Context

Seen as a bug, see comment #333 (comment)

How to test this PR

All should work:

zonemaster-cli --show-testcase --test basic/basic01 kyoto
zonemaster-cli --show-testcase --test BASIC/BASIC01 melbourne
zonemaster-cli --show-testcase --test BAsiC rio
zonemaster-cli --show-testcase --test bAsIc/BaSiC01 quebec

@ghost ghost added this to the v2023.2 milestone Jul 3, 2023
@ghost ghost requested review from hannaeko, marc-vanderwal, matsduf, mattias-p and tgreenx July 3, 2023 14:01
@ghost ghost mentioned this pull request Jul 3, 2023
Merged
matsduf
matsduf previously approved these changes Jul 3, 2023
View reviewed changes
@ghost ghost merged commit 0378063 into zonemaster:develop Jul 4, 2023
@ghost ghost deleted the test-option-case-insensitive branch November 22, 2023 13:06
@matsduf matsduf mentioned this pull request Dec 11, 2023
Closed
@mattias-p
Copy link
Member

mattias-p commented Jan 15, 2024

v2023.2 Release Testing

I successfully tested this on Rocky Linux 8.9.

@mattias-p mattias-p added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jan 15, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattias-p mattias-p Awaiting requested review from mattias-p

@hannaeko hannaeko Awaiting requested review from hannaeko

@tgreenx tgreenx Awaiting requested review from tgreenx

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees

No one assigned

Labels

S-ReleaseTested Status: The PR has been successfully tested in release testing

Projects

None yet

Milestone

v2023.2

Development

Successfully merging this pull request may close these issues.

2 participants

@mattias-p @matsduf