Make dist generate MO files for inclusion in the dist file.

[mattias-p]

Purpose

This PR updates make dist to generate the MO files before creating the tarball.
As a drive-by, some clean-up is also performed on Makefile.PL.

Context

Fixes #442.

Changes

• Add a dedicated make target make -C share mo to only generate all MO files.
• Make make dist depend on make -C share mo. Maybe there are simpler and better ways to achieve this, but the best I could come up with was:
  1. Add a new target make mydist that runs both make -C share mo and make tardist in that order.
  2. Override DIST_DEFAULT from tardist to mydist.
• Clean-ups in Makefile.PL:
  • Avoid reimplementing the share/Makefile mechanism
  • Use make -C share instead of cd share && make
  • Declare phony targets as such
  • Tidy Makefile.PL according to .perltidyrc

Testing

I tested this by executing the following and verifying that all of the MO files were listed.

rm -f Zonemaster-CLI-*.tar.gz && git clean -dfx && perl Makefile.PL && make dist && clear && tar tvf Zonemaster-CLI-*.tar.gz | grep mo

I have not tested this on FreeBSD. My hypothesis is that the share/Makefile mechanism is able switch to gmake on FreeBSD, but I haven't actually tested it.

[tgreenx]

LGTM. Tested and works as advertised.

@marc-vanderwal please review this solution, which should fix #442
@matsduf could you test this on FreeBSD? (cf. "How to test" section)

[matsduf]

It works on FreeBSD, but it is not possible to run run make distcheck before make all or make dist has been run. I think it makes more sense to run make all before make dist to be able to run make distcheck before make dist.

Maybe make distcheck should be included, and make dist not run if distcheck fails.

[matsduf]

It is important that make distcheck is included in the process. It would be nice of make dist makes it all, but then make distcheck should be automatically run before the distribution file is created, and the latter should be blocked if MANIFEST is not up to date.