Update Address01 implementation

[tgreenx]

Purpose

This PR proposes an update to the implementation of Address01 following a specification update.

Context

Based on:

• Test case specification: Update specification of ADDRESS01 zonemaster#1284
• Test scenarios specification: Test scenarios for Address01 zonemaster#1296

Changes

• lib/Zonemaster/Engine/Constants.pm
• lib/Zonemaster/Engine/Test/Address.pm
• share/profile.{json, yaml}
• t/Test-address.t : updated and refactored
• t/Test-address01.t : added

How to test this PR

Unit tests are added/updated and should pass.

[matsduf]

The PR is still in draft state.

[tgreenx]

@tolvmannen @matsduf This PR is now ready for review. Note that unit tests are updated and should all pass, which is the case for specific test scenarios of Address01 located in t/Test-address01.t, but for t/Test-address.t one test fails which is due to the same issue in other PRs (i.e. zut-root.rd.nic.fr is currently offline). It should be resolved early next week.

[matsduf]

Have you considered using the format introduced by #1467 instead?

[matsduf]

This is fine, but all tests should pass before merge. Either if the problematic server comes up or if the failing tests are marked as TODO. In the latter case the tests could possibly replaced by scenario based tests. The scenarios for this test case pass.

[matsduf]

Two scenarios fail when testing with zonemaster-cli:

| Scenario name         | Mandatory message tag                                                         | Forbidden message tags |                                         
|:----------------------|:------------------------------------------------------------------------------|:-----------------------|                                         
| GOOD-1                | A01_GLOBALLY_REACHABLE_ADDR                                                   | 2)                     |                                         

* (2) All tags except for those specified as “Mandatory message tags”

```                                                                                                                                                                        
$ zonemaster-cli --show-testcase --level INFO --test address01 --hints ../../COMMON/hintfile --raw good-1.address01.xa                                                     
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v8.0.0                                                                                                             
   0.03 CRITICAL Address01      A01_NO_NAME_SERVERS_FOUND                                                                                                                  
   0.03 INFO     Address01      A01_GLOBALLY_REACHABLE_ADDR                                                                                                                
```                                                                                                                                                                        
--> Not OK, *A01_NO_NAME_SERVERS_FOUND* unexpected.

and

| Scenario name         | Mandatory message tag                                                         | Forbidden message tags |                                         
|:----------------------|:------------------------------------------------------------------------------|:-----------------------|                                         
| NO-NAME-SERVERS       | A01_NO_NAME_SERVERS_FOUND   | 2)                     |                                                                                           

* (2) All tags except for those specified as “Mandatory message tags”

```                                                                                                                                                                        
$ zonemaster-cli --show-testcase --level INFO --test address01 --hints ../../COMMON/hintfile --raw no-name-servers.address01.xa                                            
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v8.0.0                                                                                                             
   0.04 CRITICAL Address01      A01_NO_NAME_SERVERS_FOUND                                                                                                                  
   0.04 INFO     Address01      A01_GLOBALLY_REACHABLE_ADDR                                                                                                                
```                                                                                                                                                                        
--> Not OK, *A01_GLOBALLY_REACHABLE_ADDR* unexpected.

[matsduf]

I have also a change request on the specification to make it easier to follow the behavior of the code, see my comments at zonemaster/zonemaster#1284.

[tgreenx]

@matsduf @tolvmannen please re-review

[matsduf]

Everything looks fine now. Only recreation of the data file is needed.

No real changes are needed.

[tgreenx]

Only recreation of the data file is needed.

@matsduf @tolvmannen Done. Also updated message ids to "address(es)". Please re-review.

[marc-vanderwal]

I successfully tested this PR for the 2025.2 release.

On my development setup, unit tests pass and t/test-Address01.t, which is introduced by this PR, is being executed. No errors occurred.

Some basic testing with internal domains which have private IPv4 addresses cause messages such as “IP address(es) intended for local use on network or service provider level” to appear in the output. On the other hand, other zones give “Globally reachable IP address(es)”.