Fix rdma-core 18 build (#50) #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rdma-core 18 build depends on many more kernel headers than rdma-core 17. Fix the CCAN includes from the rdma-core 18 headers because the directory structure in rdma-core was modified, whereas we keep a more vanilla layout. Add all of the userspace ABI kernel headers to the source tree so we can build against the newer rdma-core version. The updated build has been tested on my local system against rdma-core 17 and 18 and appears to work correctly. Signed-off-by: Patrick MacArthur <patrick@patrickmacarthur.net>
The include files that we added were not visible to the build system so they were not included in generated tarballs. Fix that. Signed-off-by: Patrick MacArthur <patrick@patrickmacarthur.net>
The rdma-core 18 headers require a modified version of ib_user_verbs.h, which we create as a separate file. Remove this copy when the user runs "make distclean" to avoid a failure during "make distcheck". Signed-off-by: Patrick MacArthur <patrick@patrickmacarthur.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rdma-core 18 build depends on many more kernel headers than
rdma-core 17. Fix the CCAN includes from the rdma-core 18 headers
because the directory structure in rdma-core was modified, whereas we
keep a more vanilla layout.
Add all of the userspace ABI kernel headers to the source tree so we can
build against the newer rdma-core version.
The updated build has been tested on my local system against rdma-core
17 and 18 and appears to work correctly.
Signed-off-by: Patrick MacArthur patrick@patrickmacarthur.net