Bugfix: unreliable typing test #1591
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This PR addresses the flaky behaviour in
test_show_typing_notificationby stabilising the asynchronous typing notification logic. The previous test intermittently failed due to a mismatch between the asynchronousshow_typing_notificationfunction and the synchronous test execution, as well as a race condition whereactive_conversation_infowas sometimes cleared before the loop completed. The PR replaces themock_typingTimer with a controlled mechanism that ensures a fixed number of loop iterations before clearingactive_conversation_info, and relaxes the assertion fromassert_called_with()toassert_called()to remove unnecessary strictness. These changes ensure the test reliably passes while still validating typing notification behaviour.Outstanding aspect(s)
External discussion & connections
Flakey test (typing notifications) #T1501How did you test this?