Skip to content

Enhance paste_graph method#436

Open
axif0 wants to merge 4 commits intozxcalc:masterfrom
axif0:paste_copy
Open

Enhance paste_graph method#436
axif0 wants to merge 4 commits intozxcalc:masterfrom
axif0:paste_copy

Conversation

@axif0
Copy link
Contributor

@axif0 axif0 commented Feb 17, 2026

Enhance paste_graph method to track new variables added during graph paste operation

c

Closes: #363

@boldar99
Copy link
Collaborator

Hi, thanks for the PR. I have started testing this and there seems to be some issues with the implementaiton:

  1. When copying from one tab to another, the parameter types are not preserved:
Screen.Recording.2026-02-17.at.15.38.30.mov
  1. This might be an IOS related issue (see Cannot copy-paste diagrams to other ZXLive instances on IOS: #437), but I am not able to paste to another window (even a simple diagram). I see you haven't included a video about this in your PR, but this is something explicitly mentioned in the issue.

@axif0
Copy link
Contributor Author

axif0 commented Feb 18, 2026

GraphScene.update_graph was dropping GraphDiff.variable_types during scene updates, causing boolean and parametric variable types to be lost. This change reapplies the stored variable_types to new_g.var_registry after diff.apply_diff, preserving correct variable type information.

cpy

@lia-approves
Copy link
Collaborator

Thanks for the PR. The copy paste works for only 1 of the 4 settings: both with and without Shift, on both different tabs and different windows. As there is an earlier PR (#433) that correctly implements for all 4 settings we will most likely award this bounty to that PR, but wish you happy hunting with your other bounty submissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy and paste doesn't bring parameters

3 participants