Conversation
|
Hello, thanks for the PR. It has the issue that Boldi described in #435 :
Nodes that don't participate in teh rewrite rule should not be highlighted. Let us know if you have any questions. |
|
Hi @kwyip thanks for the PR. It looks promising but can you address Lia's comment and also fix the checks that are failing? |
Sorry for the late reply. I am currently working on this particular PR right now. |
|
Hi @lia-approves @RazinShaikh zxlive_190_2.mp4 |
|
Hi, |
|
In addition to that, there should be a toggle in settings to have highlight differences on/off |
|
Hi @boldar99 @RazinShaikh , zxlive_190_3.movLet me also add the toggle functionality. |
|
Could you try applying many different rewrites (including color change) and see if it always works? I don't remember which sequence of rewrites break this |
|
Here is an example. Colour change as well as Strong complementarity are highlighted incorrectly. Screen.Recording.2026-02-28.at.01.11.09.mov |
|
Other example with fusion: Screen.Recording.2026-02-28.at.01.14.22.mov |
Hi @RazinShaikh @boldar99 , I realized what’s wrong in the video above. Essentially, the highlights for every rule (except remove parallel edges, which I don't know how to apply) are correct if one adds a rewrite step, clicks on the previous rewrite, and then views the highlight. If one does that for every step, all the highlights are correct. However, if one adds rewrite steps all at once without clicking anything on the right-side panel, the highlights for most of the steps fail (by some shifts in highlighed vertices). After realizing the issue and that most users would do the latter, I have not been able to fix it for now.If you could provide any hints, I would really appreciate it. |
Aim to fix #190
For example, in fusing two nodes the new node and a neighboring node are highlighted, as in Lia's example.
But...
zxlive_190.mp4