Draft
Conversation
- Collect all dirty vertices and edges into sets before refreshing, so each VItem/EItem is refreshed exactly once regardless of how many diff categories it appears in. - Add _bulk_updating flag to GraphScene to suppress the VItem.itemChange cascade (triggered by setPos/setSelected) during update_graph, since the deduplication pass already handles all necessary refreshes. - Disable view updates for the duration of update_graph to prevent per-item repaint scheduling and BSP tree rebuilds. - Add cascade_edges parameter to VItem.refresh() so update_graph can skip per-vertex edge cascades and handle edges in a single batch. - Use vertex_map for O(1) lookups in select_vertices instead of iterating all scene items.
- Track _last_type to skip setPath() when vertex type is unchanged (phase-only or position-only changes no longer rebuild the path) - Remove redundant setPen from update_shape (overwritten by refresh) - Remove redundant QPen copy constructor in EItem.refresh - Inline update_shape logic into refresh and remove dead method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.