Skip to content

Conversation

@CNSeniorious000
Copy link
Contributor

The py.typed was added, but you didn't define all in init.py. As a result, Pyright is throwing an error:

Error: "extract_text" is not exported from module "html_text"
  Import from "html_text.html_text" instead (reportPrivateImportUsage)

By default, Pyright treats imported symbols as private unless they are explicitly re-exported, for example, with from .html_text import parse_html as parse_html. This means we need to explicitly declare __all__ to make them public.

Honestly, I find this a bit redundant in most cases 😂

@Gallaecio Gallaecio requested a review from wRAR February 19, 2025 09:18
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (6314a62) to head (0178150).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   94.23%   94.28%   +0.05%     
==========================================
  Files           2        2              
  Lines         104      105       +1     
  Branches       19       19              
==========================================
+ Hits           98       99       +1     
  Misses          4        4              
  Partials        2        2              
Files with missing lines Coverage Δ
html_text/__init__.py 100.00% <100.00%> (ø)

@wRAR
Copy link
Member

wRAR commented Feb 19, 2025

Can you please check if you can remove --implicit-reexport from tox.ini?

Copy link
Member

@wRAR wRAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wRAR wRAR merged commit 6fbd11b into zytedata:master Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants