-
Notifications
You must be signed in to change notification settings - Fork 0
Check boot mode to validate parameter HostNumber #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integ_sp7
Are you sure you want to change the base?
Conversation
|
bootmodehostnumberbiosactive.txt Tested on Morocco, kenya, and congo |
|
Issue async dbus service get property request early enough for it to complete such that we have boot mode available before any URL requests for the resource bios_active with parameter HostNumber can be issued. |
6538587 to
d302752
Compare
|
Since we know the dbus service and the property, object mapper services need not be availed but getProperty will not work since the query can not block for the response to arrive. |
d302752 to
e34b34a
Compare
|
Return error (message) for missing, incorrect, or invalid HostNumber parameter value. |
e34b34a to
e14b7ae
Compare
|
Changed to use getProperty but we still can not use dbus::utility:: for getProperty as current version does not support Multi Node [2x1P] Single Node [2P-Default] root@morocco-0075: |
e14b7ae to
f77e66a
Compare
|
Refactored the code to eliminate a once time service and send a dbus service call as needed. |
f77e66a to
3525ea0
Compare
|
Should check boot mode only if the host number is 0 |
redfish-core/lib/update_service.hpp
Outdated
| return; | ||
| } | ||
| BMCWEB_LOG_DEBUG("boot mode: {}", bmode); | ||
| processUpdateServiceFirmwareInventoryGet(hostNumber, asyncResp, param); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line - processUpdateServiceFirmwareInventoryGet we already making call down
Identify boot mode of the system using an existing dbus service. Boot mode for Single Node [2P-Default] is 0 and it is 1 for Multi-Node [2x1P]. Check the URL for resource bios_active and parameter HostNumber. If the boot mode is Multi-Node [2x1P] and HostNumber is 0, return an error. 0 is not a valid parameter HostNumber value for the resource bios_active on Multi-Node [2x1P] systems. Tested: Verified on Multi-Node [2x1P] and Single Node [2P-Default] systems. Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
3525ea0 to
8445219
Compare
Identify boot mode of the system using an existing dbus service. Boot mode for Single Node [2P-Default] is 0 and it is 1 for Multi-Node [2x1P].
Check the URL for resource bios_active and parameter HostNumber. If the boot mode is Multi-Node [2x1P] and HostNumber is 0, return an error.
0 is not a valid parameter HostNumber value for the resource bios_active on Multi-Node [2x1P] systems.
Tested:
Verified on Multi-Node [2x1P] and Single Node [2P-Default] systems.