Fix Python portability/module dependency issues #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves Python portability by replacing collections.abc.Iterable with typing.Iterable for better compatibility with older Python 3 versions, and implements lazy imports for server services to eliminate unnecessary transitive dependencies when those services are not used.
- Replaced
collections.abc.Iterablewithtyping.Iterablein the adb module - Moved service imports from module-level to function-level in
lgl_android_install.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lglpy/android/adb.py | Changed import from collections.abc.Iterable to typing.Iterable for better Python 3 compatibility |
| lgl_android_install.py | Moved service_gpu_timeline and service_gpu_profile imports to function scope to avoid loading unnecessary dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use typing to improve compatibility with older Python3 versions.
Import Python server services on demand to remove transitive dependencies when unused.
Fixes #147