Skip to content

Fix Python portability/module dependency issues #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solidpixel merged 2 commits into from
Dec 8, 2025
Merged

Fix Python portability/module dependency issues #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d74fb
Use typing.Iterable not collections.abc.Iterable
solidpixel Dec 8, 2025
b06217a
Import servers only when used
solidpixel Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lgl_android_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@
from lglpy.android.utils import AndroidUtils, NamedTempFile
from lglpy.android.filesystem import AndroidFilesystem
from lglpy.comms import server
from lglpy.comms import service_gpu_timeline
from lglpy.comms import service_gpu_profile
from lglpy.ui import console

# Android 9 is the minimum version supported for our method of enabling layers
Expand Down Expand Up @@ -612,10 +610,14 @@ def configure_server(conn: ADBConnect,
instance = server.CommsServer(0)

if timeline_file:
# Import late to avoid pulling in transitive deps when unused
from lglpy.comms import service_gpu_timeline
service_tl = service_gpu_timeline.GPUTimelineService(timeline_file)
instance.register_endpoint(service_tl)

if profile_dir:
# Import late to avoid pulling in transitive deps when unused
from lglpy.comms import service_gpu_profile
service_prof = service_gpu_profile.GPUProfileService(profile_dir)
instance.register_endpoint(service_prof)

Expand Down
3 changes: 1 addition & 2 deletions lglpy/android/adb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@
line tool which can be used to run commands on a connected Android device.
'''

from collections.abc import Iterable
import os
import shlex
import shutil
import subprocess as sp
from typing import Optional
from typing import Iterable, Optional


class ADBConnect:
Expand Down