Breakout Room 12 - Implementing Mad Libs Generator#13
Breakout Room 12 - Implementing Mad Libs Generator#13anselrognlie wants to merge 1 commit intomainfrom
Conversation
collette7
left a comment
collette7
left a comment
There was a problem hiding this comment.
Overall looks good, left some feedback to consider!
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
There was a problem hiding this comment.
Consider leaving comments that explain implementation choices rather than describing what the code is doing.
using#is more pythonic choice over //
Review lines 2, 5, 12 & 22
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") |
There was a problem hiding this comment.
Consider re-formatting your code, it could use spaces after the commas
"Be kind to your",noun,"- footed", plural_noun) -> "Be kind to your", noun, "- footed", plural_noun)
There was a problem hiding this comment.
Consider re-formatting your code, it could use spaces after the last word of the string, currently you might receive an unexpected format
There was a problem hiding this comment.
Consider a for loop for the print statement logic. Also using f stings might make your code cleaner and easier to read
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
consider using a class for the input variables, so this could be reusable as we scale in the future
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" |
There was a problem hiding this comment.
Consider leaving comments that explain implementation choices rather than describing what the code is doing.
3 participants
No description provided.