Skip to content

Breakout Room 12 - Implementing Mad Libs Generator #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anselrognlie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 12 - Implementing Mad Libs Generator #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions main.py
View file
Open in desktop
Copy link
Collaborator

@collette7 collette7 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a for loop for the print statement logic. Also using f stings might make your code cleaner and easier to read

Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Collaborator

@collette7 collette7 Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving comments that explain implementation choices rather than describing what the code is doing.

using#is more pythonic choice over //

Review lines 2, 5, 12 & 22

loop = 1
while (loop < 9):
// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Comment on lines +6 to +11
Copy link
Collaborator

@collette7 collette7 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using a class for the input variables, so this could be reusable as we scale in the future

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
Comment on lines +14 to +19
Copy link
Collaborator

@collette7 collette7 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider re-formatting your code, it could use spaces after the commas
"Be kind to your",noun,"- footed", plural_noun) -> "Be kind to your", noun, "- footed", plural_noun)

Copy link
Collaborator

@collette7 collette7 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider re-formatting your code, it could use spaces after the last word of the string, currently you might receive an unexpected format

print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
Copy link
Collaborator

@collette7 collette7 Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving comments that explain implementation choices rather than describing what the code is doing.

loop = loop + 1