Breakout Room 1 - Implementing Mad Libs Generator

[anselrognlie]

No description provided.

[johendrickson]

Finished the in-class activity for practicing code reviews.

[johendrickson]

Suggested change

	print ("Be kind to your",noun,"- footed", plural_noun)
	print(f"Be kind to your {noun}-footed {plural_noun}")

Consider using string interpolation instead of string concatenation. This makes it less likely to make formatting mistakes when combining strings.

[johendrickson]

Suggested change

	print ("For a duck may be somebody's", seond_noun,",")
	print ("For a duck may be somebody's", second_noun,",")

It appears there's a typo here with seond_noun, it should match the variable second_noun or else this will raise a NameError.

[johendrickson]

Suggested change

	//Loop back to this point once code finishes
	#Loop back to this point once code finishes

On lines 2, 5, 12, 22 the incorrect syntax for comments is being used. For Python, we use # for commenting, this looks like JavaScript.

[johendrickson]

Suggested change

	loop = 1
	while (loop < 9):
	while loop < 9:

This while loop is incorrectly formatted to have parentheses. This is JavaScript syntax and this should be in Python. Another thing is that it looks like this loop only runs a total of 8 times, but the project requires generating 10 stories. In this case, a for loop might be better since we know the exact number of times we need to loop.

Suggested change

	loop = 1
	while (loop < 9):
	while for i in range(10):