Skip to content

Breakout Room 1 - Implementing Mad Libs Generator #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anselrognlie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 1 - Implementing Mad Libs Generator #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Collaborator

@johendrickson johendrickson Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Loop back to this point once code finishes
#Loop back to this point once code finishes

On lines 2, 5, 12, 22 the incorrect syntax for comments is being used. For Python, we use # for commenting, this looks like JavaScript.

loop = 1
while (loop < 9):
Comment on lines +3 to +4
Copy link
Collaborator

@johendrickson johendrickson Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loop = 1
while (loop < 9):
while loop < 9:

This while loop is incorrectly formatted to have parentheses. This is JavaScript syntax and this should be in Python. Another thing is that it looks like this loop only runs a total of 8 times, but the project requires generating 10 stories. In this case, a for loop might be better since we know the exact number of times we need to loop.

Suggested change
loop = 1
while (loop < 9):
while for i in range(10):

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
Copy link
Collaborator

@johendrickson johendrickson Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print ("Be kind to your",noun,"- footed", plural_noun)
print(f"Be kind to your {noun}-footed {plural_noun}")

Consider using string interpolation instead of string concatenation. This makes it less likely to make formatting mistakes when combining strings.

print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

@johendrickson johendrickson Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print ("For a duck may be somebody's", seond_noun,",")
print ("For a duck may be somebody's", second_noun,",")

It appears there's a typo here with seond_noun, it should match the variable second_noun or else this will raise a NameError.

print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1