Breakout Room 3 - Implementing Mad Libs Generator#4
Breakout Room 3 - Implementing Mad Libs Generator#4anselrognlie wants to merge 1 commit intomainfrom
Conversation
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
There was a problem hiding this comment.
Consider adding a space here for consistency! "// Loop back..."
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") | ||
| // Displays the story based on the users input | ||
| print ("------------------------------------------") |
There was a problem hiding this comment.
Consider using printf for the below statements or splitting up one statement into multilines (combine all the print statements) so that you aren't using so many separate print statements
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" |
There was a problem hiding this comment.
I think that this comment is a little unclear, and makes it seem like you're setting the value of 'loop' = 1 -- given that the structure is a while loop, you don't necessarily need to have this comment! But another way that you could state this information is to instead may say that you are looping back to the top of the while loop.
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
Completely optional, but you could use "loop += 1" instead -- different syntax, same result!
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
There was a problem hiding this comment.
The conditions of the game are that the user should be able to create 10 stories -- because 'loop' starts at 1 and you set the condition to while(loop < 9), this only runs 8 times. I would change loop = 0, and the condition to be < 10 or <= 9!
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Might be good to clarify that this is the second noun, otherwise user may just give the first noun again!
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Refer to my comment above about the second noun.
3 participants
No description provided.