Skip to content

Breakout Room 3 - Implementing Mad Libs Generator #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anselrognlie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 3 - Implementing Mad Libs Generator #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a space here for consistency! "// Loop back..."

loop = 1
while (loop < 9):
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditions of the game are that the user should be able to create 10 stories -- because 'loop' starts at 1 and you set the condition to while(loop < 9), this only runs 8 times. I would change loop = 0, and the condition to be < 10 or <= 9!

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to clarify that this is the second noun, otherwise user may just give the first noun again!

place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to my comment above about the second noun.

// Displays the story based on the users input
print ("------------------------------------------")
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using printf for the below statements or splitting up one statement into multilines (combine all the print statements) so that you aren't using so many separate print statements

print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this comment is a little unclear, and makes it seem like you're setting the value of 'loop' = 1 -- given that the structure is a while loop, you don't necessarily need to have this comment! But another way that you could state this information is to instead may say that you are looping back to the top of the while loop.

loop = loop + 1
Copy link
Collaborator

@ellenjin ellenjin Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely optional, but you could use "loop += 1" instead -- different syntax, same result!