Breakout Room 8 - Implementing Mad Libs Generator#9
Open
anselrognlie wants to merge 1 commit intomainfrom
Open
Breakout Room 8 - Implementing Mad Libs Generator#9anselrognlie wants to merge 1 commit intomainfrom
anselrognlie wants to merge 1 commit intomainfrom
Conversation
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
Collaborator
There was a problem hiding this comment.
Reviewing the readme the project is requesting to have the user loop through the mad lib generator 10 times. Consider this code written below instead.
Suggested change
| while (loop < 9): | |
| while (loop < 11): |
Collaborator
There was a problem hiding this comment.
For lines 2, 5, 12, and 22 wondered if these were comments written in another language? Consider changing them to # s if you are writing in Python.
Comment on lines
+14
to
+19
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") |
Collaborator
There was a problem hiding this comment.
Considerations for punctuation and misspelled words. Let me know your thoughts.
Suggested change
| print ("Be kind to your",noun,"- footed", plural_noun) | |
| print ("For a duck may be somebody's", seond_noun,",") | |
| print ("Be kind to your",plural_noun,"in",place) | |
| print ("Where the weather is always",adjective,".") | |
| print () | |
| print ("You may think that is this the",third_noun,",") | |
| print ("Be kind to your" {noun} "- footed" {plural_noun}) | |
| print ("For a duck may be somebody's" {second_noun} ",") | |
| print ("Be kind to your" {plural_noun} "in", {place}) | |
| print ("Where the weather is always" {adjective} ".") | |
| print () | |
| print ("You may think that is this the" {third_noun} ",") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.