Skip to content

Breakout Room 8 - Implementing Mad Libs Generator#9

Open
anselrognlie wants to merge 1 commit intomainfrom
Breakout-Room-8
Open

Breakout Room 8 - Implementing Mad Libs Generator#9
anselrognlie wants to merge 1 commit intomainfrom
Breakout-Room-8

Conversation

@anselrognlie
Copy link

No description provided.

#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the readme the project is requesting to have the user loop through the mad lib generator 10 times. Consider this code written below instead.

Suggested change
while (loop < 9):
while (loop < 11):

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For lines 2, 5, 12, and 22 wondered if these were comments written in another language? Consider changing them to # s if you are writing in Python.

Comment on lines +14 to +19
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considerations for punctuation and misspelled words. Let me know your thoughts.

Suggested change
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Be kind to your" {noun} "- footed" {plural_noun})
print ("For a duck may be somebody's" {second_noun} ",")
print ("Be kind to your" {plural_noun} "in", {place})
print ("Where the weather is always" {adjective} ".")
print ()
print ("You may think that is this the" {third_noun} ",")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants