Skip to content

Breakout Room 8 - Implementing Mad Libs Generator #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anselrognlie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 8 - Implementing Mad Libs Generator #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions main.py
View file
Open in desktop
Copy link
Collaborator

@kineticbelle kineticbelle Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For lines 2, 5, 12, and 22 wondered if these were comments written in another language? Consider changing them to # s if you are writing in Python.

Original file line number Diff line number Diff line change
@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

@kineticbelle kineticbelle Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing the readme the project is requesting to have the user loop through the mad lib generator 10 times. Consider this code written below instead.

Suggested change
while (loop < 9):
while (loop < 11):

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
Comment on lines +14 to +19
Copy link
Collaborator

@kineticbelle kineticbelle Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considerations for punctuation and misspelled words. Let me know your thoughts.

Suggested change
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Be kind to your" {noun} "- footed" {plural_noun})
print ("For a duck may be somebody's" {second_noun} ",")
print ("Be kind to your" {plural_noun} "in", {place})
print ("Where the weather is always" {adjective} ".")
print ()
print ("You may think that is this the" {third_noun} ",")

print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1