Conversation
| deployAll: ${{ inputs.deployAll }} | ||
| env: ${{ inputs.env || 'prod' }} | ||
| baseSha: ${{ inputs.baseSha || '' }} | ||
| deployAll: ${{ inputs.deployAll || true }} |
There was a problem hiding this comment.
you should set default on line 25 instead.
is this a work-around for https://jira.corp.adobe.com/browse/DEVSITE-1972? otherwise, i'm not sure we want this checked by default, because it might overload EDS server
There was a problem hiding this comment.
it's a fallback that we can pick, this is from commerce
| baseSha: ${{ inputs.baseSha }} | ||
| deployAll: ${{ inputs.deployAll }} | ||
| env: ${{ inputs.env || 'prod' }} | ||
| baseSha: ${{ inputs.baseSha || '' }} |
There was a problem hiding this comment.
do we need this? it already defaults to blank today e.g. https://github.com/AdobeDocs/adp-devsite-github-actions-test/actions/workflows/deploy.yml
There was a problem hiding this comment.
same reason as above
| env: ${{ inputs.env }} | ||
| baseSha: ${{ inputs.baseSha }} | ||
| deployAll: ${{ inputs.deployAll }} | ||
| env: ${{ inputs.env || 'prod' }} |
There was a problem hiding this comment.
do we need this? it already defaults to prod on line 13
There was a problem hiding this comment.
this is because if it's from a push event, the inputs can be not available at all, meaning it can be like a null or undefined, so it's needed to have a fallback
melissag-ensemble
left a comment
melissag-ensemble
left a comment
There was a problem hiding this comment.
please see comments about defaults
2 participants
To update the workflow to only do prod and stage separately how commerce suggested.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: