Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
---
name: Deployment
on:
push:
branches:
- main
workflow_dispatch:
inputs:
env:
description: "Select environment to deploy to"
type: choice
required: true
default: "stage"
default: "prod"
options:
- stage
- prod
- stage & prod
- "prod"
- "stage & prod"
baseSha:
description: "Use base SHA commit to deploy from (empty string defaults to last commit before HEAD)"
type: string
Expand All @@ -26,6 +28,6 @@ jobs:
name: Deployment
uses: AdobeDocs/adp-devsite-workflow/.github/workflows/deploy.yml@main
with:
env: ${{ inputs.env }}
baseSha: ${{ inputs.baseSha }}
deployAll: ${{ inputs.deployAll }}
env: ${{ inputs.env || 'prod' }}
Copy link
Contributor

@melissag-ensemble melissag-ensemble Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? it already defaults to prod on line 13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because if it's from a push event, the inputs can be not available at all, meaning it can be like a null or undefined, so it's needed to have a fallback

baseSha: ${{ inputs.baseSha || '' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same reason as above

deployAll: ${{ inputs.deployAll || true }}
Copy link
Contributor

@melissag-ensemble melissag-ensemble Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should set default on line 25 instead.

is this a work-around for https://jira.corp.adobe.com/browse/DEVSITE-1972? otherwise, i'm not sure we want this checked by default, because it might overload EDS server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a fallback that we can pick, this is from commerce

22 changes: 22 additions & 0 deletions .github/workflows/stage.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Staging
on:
workflow_dispatch:
inputs:
baseSha:
description: "Use base SHA commit to deploy from (empty string defaults to last commit before HEAD)"
type: string
required: false
default: ""
deployAll:
description: "Force deploy all files"
type: boolean
default: false
jobs:
deployment:
name: Deployment
uses: AdobeDocs/adp-devsite-workflow/.github/workflows/deploy.yml@main
with:
env: stage
baseSha: ${{ inputs.baseSha }}
deployAll: ${{ inputs.deployAll }}
1 change: 0 additions & 1 deletion src/pages/redirects.json

This file was deleted.