-
Notifications
You must be signed in to change notification settings - Fork 0
update workflow #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update workflow #25
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,19 @@ | ||
| --- | ||
| name: Deployment | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
| inputs: | ||
| env: | ||
| description: "Select environment to deploy to" | ||
| type: choice | ||
| required: true | ||
| default: "stage" | ||
| default: "prod" | ||
| options: | ||
| - stage | ||
| - prod | ||
| - stage & prod | ||
| - "prod" | ||
| - "stage & prod" | ||
| baseSha: | ||
| description: "Use base SHA commit to deploy from (empty string defaults to last commit before HEAD)" | ||
| type: string | ||
|
|
@@ -26,6 +28,6 @@ jobs: | |
| name: Deployment | ||
| uses: AdobeDocs/adp-devsite-workflow/.github/workflows/deploy.yml@main | ||
| with: | ||
| env: ${{ inputs.env }} | ||
| baseSha: ${{ inputs.baseSha }} | ||
| deployAll: ${{ inputs.deployAll }} | ||
| env: ${{ inputs.env || 'prod' }} | ||
| baseSha: ${{ inputs.baseSha || '' }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need this? it already defaults to blank today e.g. https://github.com/AdobeDocs/adp-devsite-github-actions-test/actions/workflows/deploy.yml
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same reason as above |
||
| deployAll: ${{ inputs.deployAll || true }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should set default on line 25 instead. is this a work-around for https://jira.corp.adobe.com/browse/DEVSITE-1972? otherwise, i'm not sure we want this checked by default, because it might overload EDS server
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's a fallback that we can pick, this is from commerce |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| name: Staging | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| baseSha: | ||
| description: "Use base SHA commit to deploy from (empty string defaults to last commit before HEAD)" | ||
| type: string | ||
| required: false | ||
| default: "" | ||
| deployAll: | ||
| description: "Force deploy all files" | ||
| type: boolean | ||
| default: false | ||
| jobs: | ||
| deployment: | ||
| name: Deployment | ||
| uses: AdobeDocs/adp-devsite-workflow/.github/workflows/deploy.yml@main | ||
| with: | ||
| env: stage | ||
| baseSha: ${{ inputs.baseSha }} | ||
| deployAll: ${{ inputs.deployAll }} |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this? it already defaults to prod on line 13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because if it's from a push event, the inputs can be not available at all, meaning it can be like a null or undefined, so it's needed to have a fallback