Treat UAS ID Types based on data type accordingly#139
Open
kc2rxo wants to merge 1 commit intoArduPilot:masterfrom
Open
Treat UAS ID Types based on data type accordingly#139kc2rxo wants to merge 1 commit intoArduPilot:masterfrom
kc2rxo wants to merge 1 commit intoArduPilot:masterfrom
Conversation
ID Types 3 and 4 are byte structures as defined in F3411-22a and should be treated as such.
Author
|
@tridge -- repinging this particular PR as it provides a fix to a rather insidious bug I uncovered for UTM Assigned IDs and Specific Session IDs. I have been running the fix on my own development units that supports Specific Session IDs, specifically the DRIP Entity Tag (DET, RFC9374) since the PR was opened without issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F3411-22a defines the UAS ID Types to have the following data types:
This PR fixes an issue (documented in #124) where the use of
ODID_COPY_STR(specifically thestrncpyfunction within it) was incorrectly truncating UAS IDs (specifically ID Types 3 and 4) on the first occurrence of a 0 or null byte.