Skip to content

ci: Retry WP core downloads in test-plugin-update #45830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
Merged

ci: Retry WP core downloads in test-plugin-update #45830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3d86bf
Setup → Set up
tbradsha Nov 7, 2025
3d26f22
Do a simple retry if WP download fails
tbradsha Nov 7, 2025
a5d626a
Add a variable sleep
tbradsha Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/files/test-plugin-update/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -eo pipefail

echo "::group::Setup database"
echo "::group::Set up database"
cat <<EOF > ~/.my.cnf
[client]
host=${MYSQL_HOST%:*}
Expand All @@ -16,7 +16,7 @@ mysql -e "drop database if exists wordpress;"
mysql -e "create database wordpress;"
echo "::endgroup::"

echo "::group::Setup WordPress"
echo "::group::Set up WordPress"
mkdir -p /var/log/php/ /var/scripts/
cd /var/www/html
sed -i 's/apachectl -D FOREGROUND/apachectl start/' /usr/local/bin/run
Expand Down
6 changes: 5 additions & 1 deletion tools/docker/bin/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ user="${APACHE_RUN_USER:-www-data}"
group="${APACHE_RUN_GROUP:-www-data}"

# Download WordPress
[ -f /var/www/html/xmlrpc.php ] || wp core download
# Sometimes it fails, and a retry would be nice:
# https://github.com/wp-cli/core-command/pull/258
# https://github.com/wp-cli/wp-cli/pull/6140
# For now this should work well enough
[ -f /var/www/html/xmlrpc.php ] || wp core download || sleep $(( 30 + RANDOM % 8 )) && wp core download
Copy link
Contributor

@anomiex anomiex Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. We both missed that this should have been something like

[ -f /var/www/html/xmlrpc.php ] || wp core download || { sleep $(( 30 + RANDOM % 8 )) && wp core download; }

Copy link
Contributor Author

@tbradsha tbradsha Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45831


# Configure WordPress
if [ ! -f /var/www/html/wp-config.php ]; then
Expand Down
Loading