831 feature request define internal forces class with coordinate system for all strength and stability checks #834

GerjanDorgelo · 2025-11-18T09:22:11Z

Description

Define internal forces class with coordinate system for all strength stability checks

Fixes #831

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist:

I have added tests that prove my fix is effective or that my feature works
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
New and existing unit tests pass locally with my changes

…stability checks

…bility checks

…t tests for validation

github-actions · 2025-11-18T09:22:19Z

Thank you so much for contributing to Blueprints!
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Copilot

Pull Request Overview

This PR introduces a new LoadCombination dataclass to represent load combinations for strength and stability checks with a well-defined coordinate system. The implementation establishes a standardized way to handle structural loads across different axes.

Key Changes:

New LoadCombination dataclass with 6 load components (normal force, shear forces, bending moments, and torsion)
Comprehensive coordinate system documentation with ASCII diagram and sign conventions
Complete test suite covering initialization, negative/zero values, equality, and hashability

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`blueprints/checks/loads/load_combination.py`	Defines the frozen `LoadCombination` dataclass with coordinate system documentation and type-annotated force/moment attributes
`blueprints/checks/loads/__init__.py`	Adds package-level docstring for the loads module
`tests/checks/loads/test_load_combination.py`	Implements comprehensive test coverage for `LoadCombination` functionality
`tests/checks/loads/__init__.py`	Adds package-level docstring for test module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

blueprints/checks/loads/load_combination.py

codecov · 2025-11-18T09:23:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0be46f2) to head (292345c).
⚠️ Report is 14 commits behind head on 840-feature-request-add-first-steel-check-to-blueprints.

Additional details and impacted files

@@                                    Coverage Diff                                    @@
##           840-feature-request-add-first-steel-check-to-blueprints      #834   +/-   ##
=========================================================================================
  Coverage                                                   100.00%   100.00%           
=========================================================================================
  Files                                                          393       395    +2     
  Lines                                                        12116     12155   +39     
=========================================================================================
+ Hits                                                         12116     12155   +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…lass-with-coordinate-system-for-all-strenthstability-checks

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

blueprints/checks/loads/load_combination.py

Copilot · 2025-11-18T13:03:43Z

@egarciamendez I've opened a new pull request, #835, to work on those changes. Once the pull request is ready, I'll request review from you.

…lass-with-coordinate-system-for-all-strenthstability-checks

SZeltaat · 2025-11-22T10:48:57Z

blueprints/checks/loads/load_combination.py

+
+
+@dataclass(frozen=True)
+class LoadCombination:


I like the idea of having a container for internal forces when performing trength or stability checks. 👍
As "naming things" is one of the hardest things in CS, I think that the name is misleading. Load combination has a different meaning in the context of civil / structural engineering and according to the Eurocode. Perhaps using the terminology of Scia would be a good idea. Here are some alternative suggestions:

InternalForces
InternalForces3D
BeamInternalForces (as opposed to plate internal forces)
...

SCIA and other software company's have joined forces long before Blueprints to try and solve this problem. We shouldn't try to reinvent the wheel.

https://www.saf.guide/en/stable/
In other words, I think we should follow SAF for this kind of things.

ResultInternalForce1D then 😃

https://www.saf.guide/en/stable/results/resultinternalforce1d.html

oh cool stuff! let me work on this then :)

I kept the structure as a class as was done before, but now with all parameters as SAF guides us. Discussion point: SAF has many input as required. for us that could mean its just default 0 or empty string. I think from a user perspective its nice to be able to ResultInternalForce1D(N=4), without having to specifiy all other parameters. you can if you want to of course.

please note: result_for is now presented as string. in a future that should be connected to the LoadCase or LoadCombination class. But as that doesnt exist yet.. string it is.

…1D class and tests, remove LoadCombination class and related tests

…oordinate-system-for-all-strenthstability-checks' of https://github.com/Blueprints-org/blueprints into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

blueprints/checks/forces/result_internal_forces_1d.py

…the coordinate system

…, add ResultInternalForce1D with updated structure and validation

…rce1D

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

blueprints/saf/results/result_internal_force_1d.py

tests/saf/forces/__init__.py

…alForce1D

…' into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks

GerjanDorgelo added 3 commits November 18, 2025 10:07

Define LoadCombination class with coordinate system for strength and …

a567134

…stability checks

Add LoadCombination class with coordinate system for strength and sta…

23525aa

…bility checks

Initialize LoadCombination attributes with default values and add uni…

73c98b0

…t tests for validation

GerjanDorgelo self-assigned this Nov 18, 2025

Copilot AI review requested due to automatic review settings November 18, 2025 09:22

GerjanDorgelo linked an issue Nov 18, 2025 that may be closed by this pull request

[✨ Feature request]: define internal forces class with coordinate system for all strenth/stability checks #831

Open

2 tasks

Copilot AI reviewed Nov 18, 2025

View reviewed changes

blueprints/checks/loads/load_combination.py Outdated Show resolved Hide resolved

blueprints/checks/loads/load_combination.py Outdated Show resolved Hide resolved

GerjanDorgelo and others added 2 commits November 18, 2025 10:29

Fix typo in LoadCombination class docstring

a6bd006

Merge branch 'main' into 831-feature-request-define-loadcombination-c…

a458270

…lass-with-coordinate-system-for-all-strenthstability-checks

Copilot AI review requested due to automatic review settings November 18, 2025 11:13

Copilot started reviewing on behalf of egarciamendez November 18, 2025 11:13 View session

Copilot finished reviewing on behalf of egarciamendez November 18, 2025 11:16

Copilot AI reviewed Nov 18, 2025

View reviewed changes

blueprints/checks/loads/load_combination.py Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Nov 18, 2025

[WIP] Address feedback on loadcombination class for strength checks #835

Closed

GerjanDorgelo mentioned this pull request Nov 18, 2025

830 feature request check for strength of steel i profiles class 3 #836

Draft

6 tasks

Merge branch 'main' into 831-feature-request-define-loadcombination-c…

553a75f

…lass-with-coordinate-system-for-all-strenthstability-checks

SZeltaat reviewed Nov 22, 2025

View reviewed changes

GerjanDorgelo changed the title ~~831 feature request define loadcombination class with coordinate system for all strenthstability checks~~ 831 feature request define internal forces class with coordinate system for all strenthstability checks Nov 23, 2025

GerjanDorgelo changed the title ~~831 feature request define internal forces class with coordinate system for all strenthstability checks~~ 831 feature request define internal forces class with coordinate system for all strength and stability checks Nov 23, 2025

GerjanDorgelo added 2 commits November 23, 2025 10:35

Refactor internal forces and loads structure: add ResultInternalForce…

a41e40c

…1D class and tests, remove LoadCombination class and related tests

Merge branch '831-feature-request-define-loadcombination-class-with-c…

6dbd357

…oordinate-system-for-all-strenthstability-checks' of https://github.com/Blueprints-org/blueprints into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks

Copilot AI review requested due to automatic review settings November 23, 2025 09:35

Copilot AI reviewed Nov 23, 2025

View reviewed changes

blueprints/checks/forces/result_internal_forces_1d.py Outdated Show resolved Hide resolved

Clarify sign conventions in ResultInternalForce1D class to reference …

222ab25

…the coordinate system

GerjanDorgelo requested review from SZeltaat and egarciamendez November 23, 2025 09:39

Refactor SAF implementation: remove internal forces classes and tests…

55796ef

…, add ResultInternalForce1D with updated structure and validation

Update error message in test for index validation in ResultInternalFo…

0f3d350

…rce1D

Copilot AI review requested due to automatic review settings November 27, 2025 18:14

Copilot AI reviewed Nov 27, 2025

View reviewed changes

blueprints/saf/results/result_internal_force_1d.py Show resolved Hide resolved

tests/saf/forces/__init__.py Show resolved Hide resolved

Update error messages in tests for missing parameters in ResultIntern…

9a1243b

…alForce1D

GerjanDorgelo changed the base branch from main to 840-feature-request-add-first-steel-check-to-blueprints November 27, 2025 18:19

Merge branch '840-feature-request-add-first-steel-check-to-blueprints…

292345c

…' into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks

egarciamendez approved these changes Nov 27, 2025

View reviewed changes

GerjanDorgelo merged commit 2b5e218 into 840-feature-request-add-first-steel-check-to-blueprints Nov 27, 2025
6 of 7 checks passed

831 feature request define internal forces class with coordinate system for all strength and stability checks #834

831 feature request define internal forces class with coordinate system for all strength and stability checks #834

Conversation

GerjanDorgelo commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI commented Nov 18, 2025

Uh oh!

SZeltaat Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

egarciamendez Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SZeltaat Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

GerjanDorgelo Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

GerjanDorgelo Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GerjanDorgelo commented Nov 18, 2025 •

edited

Loading

codecov bot commented Nov 18, 2025 •

edited

Loading

egarciamendez Nov 22, 2025 •

edited

Loading