-
Notifications
You must be signed in to change notification settings - Fork 17
830 feature request check for strength of steel i profiles class 3 #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 840-feature-request-add-first-steel-check-to-blueprints
Are you sure you want to change the base?
Conversation
…t tests for validation
…lass-with-coordinate-system-for-all-strenthstability-checks
…cording to Eurocode 3
… class and enhance latex output; add unit tests for validation.
…fy parameters and add details for NormalForceCheck class.
…Steel I-Profile strength class 3
…tor heb_profile fixture
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a showcase implementation of automated steel strength checks for Class 3 I-profiles according to Eurocode 3. The implementation demonstrates a structure for performing multiple sub-checks using various formulas, specifically focusing on normal force resistance checks for both tension and compression cases.
Key changes:
- Introduces
LoadCombinationdataclass to represent load combinations with clear sign conventions - Implements
SteelIProfileStrengthClass3with a nestedNormalForceCheckclass for evaluating normal force resistance - Provides comprehensive test coverage for both the main check class and the normal force sub-check
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
blueprints/checks/loads/load_combination.py |
Defines a frozen dataclass representing load combinations with detailed documentation of axis conventions and sign definitions |
blueprints/checks/steel/strength/steel_i_profile_strength_class_3.py |
Implements the main strength check class with a nested normal force check that applies Eurocode 3 formulas for tension and compression |
tests/checks/loads/test_load_combination.py |
Comprehensive tests for LoadCombination including initialization, equality, and hashability |
tests/checks/steel/strength/test_steel_i_profile_strength_class_3.py |
Tests for both the main check class and the normal force sub-check, including parametrized LaTeX output validation |
tests/checks/steel/strength/conftest.py |
Provides a reusable fixture for creating HEB300 profile instances with section properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blueprints/checks/steel/strength/steel_i_profile_strength_class_3.py
Outdated
Show resolved
Hide resolved
blueprints/checks/steel/strength/steel_i_profile_strength_class_3.py
Outdated
Show resolved
Hide resolved
…lation; update test fixture documentation.
…eel-i-profiles-class-3
…lass-with-coordinate-system-for-all-strenthstability-checks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 840-feature-request-add-first-steel-check-to-blueprints #836 +/- ##
==========================================================================================
Coverage 100.00% 100.00%
==========================================================================================
Files 393 395 +2
Lines 12106 12271 +165
==========================================================================================
+ Hits 12106 12271 +165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ileStrengthClass3
…enhance LaTeX formatting and improve test cases for compression checks.
…enhance LaTeX formatting for short and detailed outputs.
…improve LaTeX representation and streamline logic for tension and compression checks.
… None area values and ensure correct tension and compression checks.
…leStrengthClass3 for clarity and update corresponding test cases.
…1D class and tests, remove LoadCombination class and related tests
…oordinate-system-for-all-strenthstability-checks' of https://github.com/Blueprints-org/blueprints into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks
…the coordinate system
…oordinate-system-for-all-strenthstability-checks' into 830-feature-request-check-for-strength-of-steel-i-profiles-class-3
… for load combinations and add single axis bending moment checks.
…Steel I-Profile strength class 3
… Steel I-Profiles
…and update method names for clarity
… simplified ResultInternalForce1D instantiation
…el I-Profile strength class 3
…validation and check for leading slashes
…eel I-Profile strength class 3
…ompression checks, update latex output validation, and refactor test structure
…rminology, update related tests for consistency, and add validation for invalid axis input.
…k axis summary test in Steel I-Profile strength class 3
…logy for bending moments, and enhance test coverage for various loading scenarios in class 3.
…e parameterized testing for single force permutations, enhancing test coverage and reducing redundancy.
…or clarity in force descriptions
Description
This branch depends on #834 and will therefore feature the same LoadCombination code once again.
This branch is a showcase of what automated steel checks using various formula and multiple sub-checks could look like. Let's discuss the structure openly before I add all other checks using sub-issues (to make sure i'm not making super big PRs).
There is a dependency in how @SZeltaat will leave a few features in his WIP branch. This code requires access to
But even with these two, for now, questions left behind us. How do we want (steel) checks using various formula and multiple sub-checks to be evaluated?
Fixes #830
Type of change
Checklist: