Small fix to CO core masses for AGB stars#762
Merged
katiebreivik merged 2 commits intoCOSMIC-PopSynth:developfrom Feb 19, 2026
Merged
Small fix to CO core masses for AGB stars#762katiebreivik merged 2 commits intoCOSMIC-PopSynth:developfrom
katiebreivik merged 2 commits intoCOSMIC-PopSynth:developfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #762 +/- ##
===========================================
- Coverage 86.91% 77.83% -9.08%
===========================================
Files 40 50 +10
Lines 25542 27517 +1975
Branches 0 921 +921
===========================================
- Hits 22198 21417 -781
- Misses 3344 5813 +2469
- Partials 0 287 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
katiebreivik
approved these changes
Feb 19, 2026
Collaborator
katiebreivik
left a comment
There was a problem hiding this comment.
Thanks @TomWagg !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #756 we changed the conditions in
assign_remnant.fto usemc_coinstead ofmc. However, we didn't ensure thatmc_cowas set tomcmaxif we overshot it. This meant that there was a timestepping issue that gave you a nonmontonic result of an SN occuring with smooth changes in initial masses and metallicity.Here's the testing script:
min_sn_crit.py
Before:

After:
