Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ See the discussed changes in our previous releases here: https://github.com/COSM
- Bug fix [[#724](https://github.com/COSMIC-PopSynth/COSMIC/issues/724)]: remove bug where ``kstar=15`` was assigned its previous epoch mass after merging during a CE and the merger product goes SN

## 3.7.2
This release contains _several_ fixes to how CO core masses/remnant masses are handled. It also adds a new PISN prescription and windflag.
This release contains _several_ fixes to how CO core masses/remnant masses are handled. It also adds a new PISN prescription, windflag and LBV winds flag.

- Fixes:
- Update ``mc_co`` and ``mc_he`` after adjusting ``mc = mcmax`` in ``hrdiag.f`` for stripped stars. This can be a fairly significant change, up to ~2 Msun. (Used to actually be up to 10 Msun because we added HeMS core mass growth)
Expand All @@ -95,6 +95,8 @@ This release contains _several_ fixes to how CO core masses/remnant masses are h
- Added a ``windflag = -1`` option to turn off stellar winds entirely
- Added ``pisn = -4`` for Renzo+22/Hendriks+23 prescription for PPISN mass loss
- With options ``ppi_co_shift`` and ``ppi_extral_ml``
- Add new setting ``LBV_flag`` which allows one to turn off LBV winds, use Hurley+2000, or use Belcyznski+2008
- Change the default LBV winds to Hurley

- Code cleanup:
- ``assign_remnant`` no longer takes ``mc_tot`` as a parameter, just get it from the common block
Expand All @@ -103,12 +105,6 @@ This release contains _several_ fixes to how CO core masses/remnant masses are h
- Got rid of ``mcx`` in ``assign_remnant`` in favour of clearer ``m_proto`` and ``m_FeNi`` to match the papers
- [Very minor] Fryer Rapid was using <= instead of < everywhere


## 3.7.3
- Additions/changes:
- Add new setting ``LBV_flag`` which allows one to turn off LBV winds, use Hurley+2000, or use Belcyznski+2008
- Change the default LBV winds to Hurley

- Documentation:
- Start new settings gallery in the documentation
- Tag settings/options with the version they were added in the docs page and auto link them to release
2 changes: 1 addition & 1 deletion src/cosmic/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "3.7.3"
__version__ = "3.7.2"
2 changes: 1 addition & 1 deletion src/cosmic/data/cosmic-settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@
"description": "Selects the model for Luminous Blue Variable (LBV) mass loss",
"type": "dropdown",
"options-preface": "",
"version_added": "3.7.3",
"version_added": "3.7.2",
"options": [
{
"name": 0,
Expand Down
3 changes: 3 additions & 0 deletions src/cosmic/src/hrdiag.f
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,10 @@ SUBROUTINE hrdiag(mass,aj,mt,tm,tn,tscls,lums,GB,zpars,
*
if(mcmax-mcx.lt.tiny)then
aj = 0.d0

! adjust core masses in case we overshot the maximum allowed core mass
mc = mcmax
mc_co(kidx) = mc
call assign_remnant(zpars,mc,mcbagb,mass,
& kidx,mt,kw,bhspin)
endif
Expand Down