add reward metric and query on mooclet create#2207
Merged
danoswaltCL merged 5 commits intodevfrom Feb 14, 2025
Merged
Conversation
danoswaltCL
force-pushed
the
feature/reward-metric-and-query-on-creation
branch
from
8bfb7da to
918c845
Compare
danoswaltCL
force-pushed
the
feature/reward-metric-and-query-on-creation
branch
from
918c845 to
17589ce
Compare
danoswaltCL
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7 and
zackcl
Collaborator
Author
|
#2210 (comment) I left a comment here that would affect this PR |
Collaborator
Author
|
@zackcl this has been updated, frontend will need to send @VivekFitkariwala @bcb37 please take a look, this one is a bit of a blocker for the rest of the mooclet stuff until it's in. ty ty |
zackcl
previously approved these changes
Feb 12, 2025
VivekFitkariwala
suggested changes
Feb 13, 2025
backend/packages/Upgrade/src/api/controllers/ExperimentController.ts
Outdated
Show resolved
Hide resolved
VivekFitkariwala
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds experiment specific reward metric and a query for percent success on mooclet experiment creation.
On experiment delete, this experiment-specific reward metric will also be deleted.
#1934