London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Form-Controls by DamianDL · Pull Request #1027 · CodeYourFuture/Module-Onboarding

DamianDL · 2026-01-23T17:21:28Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Forms updated to collect name and email to validate user and pick specific requirements of the T-shirt from list, for colour and size.

Questions

netlify · 2026-01-23T17:21:34Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`b1630fe`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/697df1095a33fc0008ab9754
😎 Deploy Preview	https://deploy-preview-1027--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 87 (🟢 up 1 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

…ks." This reverts commit a0943dd.

DamianDL · 2026-01-26T16:01:20Z

Please can I have some help.

I have managed to revert the branch back to the initial commit, but cannot revert it back to the original Wireframe files.. I have done this using the git revert . Where can I find the hex id for the unchanged branch? Or should I use another command/approach? Thanks.

…ith Origional/main

…Origional/main-second attempt

DamianDL · 2026-01-29T13:59:29Z

Updated with changes to meet requirements;

I have used HTML only.
I have not used any CSS or JavaScript.

HTML

My form is semantic html.
All inputs have associated labels.
My Lighthouse Accessibility score is 100.
I require a valid name. I have defined a valid name as a text string of two characters or more.
I require a valid email of the format "texx@text.text"
I require one colour from a defined set of 3 colours.- Red, Blue, Green
I require one size from a defined set of 6 sizes. -XS, S, M, L, XL, XXL

cjyuan

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

Form-Controls/index.html

cjyuan · 2026-01-29T21:54:34Z

Form-Controls/index.html

+        <div>
+          <!-- Email: basic format text@text.text -->
+          <label for="email">Email:</label>
+          <input type="email" id="email" name="email" required pattern="^[^@\s]+@[^@\s]+\.[^@\s]+$" title="Enter a valid email like user@example.com">


Why use pattern in <input type="email"> when browsers can already perform built-in email validation?

Form-Controls/index.html

cjyuan · 2026-01-29T22:03:03Z

In the Changelist section of the PR description, I am not sure what you mean by "How to save attributes". Can you update it accordingly to give a brief but clearer description of what you have changed in this PR branch?

…n be a space

DamianDL · 2026-01-30T10:04:28Z

CJ-Thanks for your clear and concise review. I believe that I have made changes to align with your comments. Thanks Damian

cjyuan

1

Code is good, but the indentation of the code could use some improvement.

2

In the Changelist section of the PR description, I am not sure what you mean by "How to save attributes". Can you update it accordingly to give a brief but clearer description of what you have changed in this PR branch?

cjyuan · 2026-01-30T16:39:19Z

Form-Controls/index.html

+    label {
+        font-size: 24px;
+    }
+</style>


Can you improve the indentation on lines 10, 41, 71-72?

You can use the VSCode's "Format Document" feature to auto-indent the code?
To use the feature, right-click inside the code editor and select the option.

cjyuan · 2026-02-01T15:41:30Z

Changes look good. Well done.

DamianDL added 7 commits January 15, 2026 12:59

Update text to answer three questions in 3 articles, with links.

a0943dd

Changes to page formatting into Wireframe template

3e10354

Update to Forms for Sprint 2 exercise

73b1697

centre header text

43967f2

refactor: cleaning up code

f7fb669

comments added and customer name input added

173fecb

putting back code deleted by mistake

31bebe9

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 23, 2026

This comment has been minimized.

Sign in to view

DamianDL added 2 commits January 26, 2026 14:01

Revert "Update text to answer three questions in 3 articles, with lin…

cf2b1ba

…ks." This reverts commit a0943dd.

form bilt for name, email, colour and size

97c68bc

DamianDL added the ⚙️ bug Something isn't working label Jan 26, 2026

This comment has been minimized.

Sign in to view

DamianDL added 2 commits January 27, 2026 10:47

replacing the Wireframe Index and CSS files in Form_Controls branch w…

8d5c720

…ith Origional/main

replacing the Wireframe Index.html file in Form_Controls branch with …

ec9f9c4

…Origional/main-second attempt

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed ⚙️ bug Something isn't working labels Jan 27, 2026

DamianDL added 2 commits January 29, 2026 13:32

Font size updated to achieve lighthouse score 100

484e648

Update Footer to my name and course

d0bb4ed

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 29, 2026

cjyuan reviewed Jan 29, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 29, 2026

Text formatting moved from body to head

175fc5e

DamianDL added 3 commits January 30, 2026 09:20

Changes as identified by validator tool

116596f

Change to email input to require minimum of two charaters, neither ca…

24d7c27

…n be a space

remove unnecessary validation of text for email type

f8ded79

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026

cjyuan reviewed Jan 30, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026

updated VSC formatter used to make code indentations easier to read

b1630fe

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026

This was referenced Feb 2, 2026

Form Controls DamianDL/My-Coursework-Planner#14

Open

Form Controls DamianDL/My-Coursework-Planner#28

Open

26-ITP-Jan | Onboarding | Damian Dunkley DamianDL/My-Coursework-Planner#31

Open

Uh oh!

Conversation

DamianDL commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

netlify bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

DamianDL commented Jan 26, 2026

Uh oh!

DamianDL commented Jan 29, 2026

HTML

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjyuan Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan commented Jan 29, 2026

Uh oh!

DamianDL commented Jan 30, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

1

2

Uh oh!

cjyuan Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DamianDL commented Jan 23, 2026 •

edited

Loading

netlify bot commented Jan 23, 2026 •

edited

Loading