Merged
Conversation
Owner
CubeBerry
commented
Feb 6, 2026
CubeBerry
commented
- Created Multiple Lights scene demo for showcasing deferred rendering.
- Removed CalculatePointLightRadius. Instead, radius is going to be handled manually by developer.
- Need to apply intensity to directional & point lights.
- Increased entire scale of multiple lights demo scene to handle point light radius (apporximately 5) properly. - Light volume covers entire scene when objects' size is around 15~20.
This reverts commit 092828e.
- Attenuation equation in shader and C++ radius calculation does not match. - Radius size can be controlled by developer.
- Both OpenGL and Vulkan's Equirectangular shader tone mapping should be removed after post-process tone mapping is implemented.
doyoung413
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.